imjasonh/client-go2
1
0
Fork 0
mirror of https://github.com/imjasonh/client-go2 synced 2026-07-08 00:55:56 +00:00
Code Activity

take runtime.Object instead of T any

Browse source
This commit is contained in:
Jason Hall 2021-09-10 14:03:39 -04:00
parent 08c01c3a33
commit b7c0e36470
2 changed files with 19 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

19
generic/client.go
View file

@ -6,21 +6,34 @@ import (
"encoding/json"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/client-go/dynamic"
"k8s.io/client-go/rest"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
func NewClient[T any](gvr schema.GroupVersionResource, config *rest.Config) client[T] {
// Ideally, this wouldn't need to take a GVR, and it could just be inferred
// from the runtime.Object type given.
//
// In practice, this doesn't seem to be straightforward. :(
//
// Things that implement runtime.Object tend to be pointer types (e.g.,
// *corev1.Pod), which means T is nil, and we can't call GetObjectKind() on it
// to start to guess at the GVR.
//
// It might be possible to use schemes to lookup the GVR for a given Go type
// (assuming it's been registered), which could let us get rid of this.
// In the meantime, taking a GVR removes ambiguity at the cost of verbosity.
// /shrug
func NewClient[T runtime.Object](gvr schema.GroupVersionResource, config *rest.Config) client[T] {
return client[T] {
gvr: gvr,
dyn: dynamic.NewForConfigOrDie(config),
}
}
type client[T any] struct {
type client[T runtime.Object] struct {
gvr schema.GroupVersionResource
dyn dynamic.Interface // TODO: don't depend on dynamic client
}

6
main.go
View file

@ -38,7 +38,7 @@ func main() {
}
// List pods in kube-system.
pods, err := generic.NewClient[corev1.Pod](podGVR, config).List(ctx, "kube-system")
pods, err := generic.NewClient[*corev1.Pod](podGVR, config).List(ctx, "kube-system")
if err != nil {
log.Fatal("listing pods:", err)
}
@ -48,8 +48,8 @@ func main() {
}
// Create a ConfigMap, then list ConfigMaps.
cmc := generic.NewClient[corev1.ConfigMap](cmGVR, config)
if err := cmc.Create(ctx, "kube-system", corev1.ConfigMap{
cmc := generic.NewClient[*corev1.ConfigMap](cmGVR, config)
if err := cmc.Create(ctx, "kube-system", &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
GenerateName: "foo-",
},