imjasonh/cnotes
1
0
Fork 0
mirror of https://github.com/imjasonh/cnotes synced 2026-07-07 00:33:04 +00:00
Code Activity

Prevent cnotes installation from temporary directories

Browse source 
- Add check for os.TempDir() and /tmp/ prefix
- Resolve symlinks to handle macOS temp directory structure
- Guide users to use 'go install' for proper installation
This commit is contained in:
Jason Hall 2025-07-21 14:57:34 -04:00
parent 3cfe51703e
commit 47abf1a0ce
Failed to extract signature
2 changed files with 395 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

380
.claude/settings.json
View file

@ -9,6 +9,60 @@
"command": "/Users/jason/go/bin/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes2"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes3"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-fail"
}
]
}
],
"PostToolUse": [
@ -20,6 +74,60 @@
"command": "/Users/jason/go/bin/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes2"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes3"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-fail"
}
]
}
],
"PreCompact": [
@ -31,6 +139,60 @@
"command": "/Users/jason/go/bin/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes2"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes3"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-fail"
}
]
}
],
"PreToolUse": [
@ -42,6 +204,60 @@
"command": "/Users/jason/go/bin/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes2"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes3"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-fail"
}
]
}
],
"Stop": [
@ -53,6 +269,60 @@
"command": "/Users/jason/go/bin/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes2"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes3"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-fail"
}
]
}
],
"SubagentStop": [
@ -64,6 +334,60 @@
"command": "/Users/jason/go/bin/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes2"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes3"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-fail"
}
]
}
],
"UserPromptSubmit": [
@ -75,7 +399,61 @@
"command": "/Users/jason/go/bin/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes2"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-cnotes3"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test"
}
]
},
{
"matcher": ".*",
"hooks": [
{
"type": "command",
"command": "/tmp/test-fail"
}
]
}
]
}
}
}

16
cmd/install.go
View file

@ -5,6 +5,7 @@ import (
"log/slog"
"os"
"path/filepath"
"strings"
"github.com/imjasonh/cnotes/internal/config"
"github.com/spf13/cobra"
@ -66,6 +67,21 @@ func runInstall(cmd *cobra.Command, args []string) error {
scope = "project"
}
// Prevent installation from temporary directories (unless uninstalling)
if !uninstall {
tempDir := os.TempDir()
// Resolve any symlinks in the executable path for comparison
realExecutable, err := filepath.EvalSymlinks(executable)
if err != nil {
realExecutable = executable // Fall back to original if can't resolve
}
// Check if executable is in temp directory
if strings.HasPrefix(realExecutable, tempDir) || strings.HasPrefix(executable, "/tmp/") {
return fmt.Errorf("cannot install from temporary directory: %s\nPlease build and install cnotes properly:\n go install && cnotes install", executable)
}
}
if uninstall {
slog.Info("uninstalling hooks", "binary", executable, "scope", scope)
if err := config.UninstallHooksFromPath(executable, settingsPath); err != nil {