continuing to struggle with reflect...

csvstruct.go

@@ -2,7 +2,10 @@ package csvstruct
 
 import (
 	"encoding/csv"
+	"errors"
+	"fmt"
 	"io"
+	"log"
 	"reflect"
 )
 
@@ -26,28 +29,34 @@ func (d decoder) DecodeNext(v interface{}) error {
 		// First run; read header row
 		header, err := d.r.Read()
 		if err != nil {
-			return err
+			return fmt.Errorf("error reading headers: %v", err)
 		}
 		d.hm = reverse(header)
 	}
 
-	t := reflect.TypeOf(v)
-
 	line, err := d.r.Read()
 	if err != nil {
 		return err
 	}
 
-	out := reflect.ValueOf(v)
+	rv := reflect.ValueOf(v)
+	if rv.Kind() != reflect.Ptr || rv.IsNil() {
+		return errors.New("must be pointer")
+	}
+
+	t := reflect.TypeOf(rv.Elem())
+	out := reflect.New(t).Elem()
 	for i := 0; i < t.NumField(); i++ {
 		f := t.Field(i)
+		if f.Anonymous {
+			continue
+		}
 		n := f.Name
-		// TODO: f.Tag.Get("csv")
+		strv := line[d.hm[n]]
-		val := line[d.hm[n]]
+		log.Printf("%s = %s\n", n, strv)
-		vval := reflect.ValueOf(&val)
+		out.FieldByName(n).SetString(strv)
-		vval.Elem().SetString(line[d.hm[n]])
-		out.Elem().Set(vval)
 	}
+	v = out
 	return nil
 }
 

csvstruct_test.go

@@ -22,16 +22,21 @@ d,e,f`,
 		out: []row{{"a", "b", "c"}, {"d", "e", "f"}},
 	}, {
 		// Rows that only have partial data are only partially filled.
+		data: `Foo,Bar,Baz
+a,,
+,b,`,
+		out: []row{{"a", "", ""}, {"", "b", ""}},
+	}, {
+		// Rows that don't define all the columns are partially filled.
 		data: `Foo,Bar
 a,
 ,b`,
 		out: []row{{"a", "", ""}, {"", "b", ""}},
-	}, {
+		/*}, {
-		// Disjoint data results in unset struct.
+				// Entirely disjoint columns produce empty structs.
-		data: `
+				data: `Qux
-Qux
+		d`,
-ignored`,
+				out: []row{{"", "", ""}}, */
-		out: []row{{"", "", ""}},
 	}} {
 		d := NewDecoder(strings.NewReader(c.data))
 		rows := []row{}
@@ -47,7 +52,7 @@ ignored`,
 			}
 			rows = append(rows, row)
 		}
-		if reflect.DeepEqual(rows, c.out) {
+		if !reflect.DeepEqual(rows, c.out) {
 			t.Errorf("unexpected result, got %v, want %v", rows, c.out)
 		}
 	}