From ffc7c82ae4ca4603a327c0ef9bb726a70ca149c8 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sat, 28 Feb 2026 00:21:10 +0000
Subject: [PATCH] Fix LeaderAware interface: use correct Promote signature

The Knative reconciler.LeaderAware interface requires:
  Promote(Bucket, func(Bucket, types.NamespacedName)) error
Our code had the wrong enqueue function signature using
(Bucket, string) error instead.

https://claude.ai/code/session_01QfFzqKQUsxxBsiZUhuJ3pG
---
 pkg/reconciler/push/push.go         | 3 ++-
 pkg/reconciler/resolver/resolver.go | 3 ++-
 pkg/reconciler/sync/sync.go         | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/pkg/reconciler/push/push.go b/pkg/reconciler/push/push.go
index 188f109..0938b17 100644
--- a/pkg/reconciler/push/push.go
+++ b/pkg/reconciler/push/push.go
@@ -12,6 +12,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/dynamic"
+	"k8s.io/apimachinery/pkg/types"
 	"knative.dev/pkg/logging"
 	"knative.dev/pkg/reconciler"
 
@@ -254,7 +255,7 @@ func splitKey(key string) (string, string, error) {
 var _ reconciler.LeaderAware = (*Reconciler)(nil)
 
 // Promote implements LeaderAware.
-func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(bkt reconciler.Bucket, key string) error) error {
+func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(reconciler.Bucket, types.NamespacedName)) error {
 	return nil
 }
 
diff --git a/pkg/reconciler/resolver/resolver.go b/pkg/reconciler/resolver/resolver.go
index 2de48a2..469d3b3 100644
--- a/pkg/reconciler/resolver/resolver.go
+++ b/pkg/reconciler/resolver/resolver.go
@@ -10,6 +10,7 @@ import (
 	"github.com/go-git/go-git/v5/plumbing/object"
 	"github.com/go-git/go-git/v5/storage/memory"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/dynamic"
 	"knative.dev/pkg/logging"
 	"knative.dev/pkg/reconciler"
@@ -303,7 +304,7 @@ func splitKey(key string) (string, string, error) {
 
 var _ reconciler.LeaderAware = (*Reconciler)(nil)
 
-func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(bkt reconciler.Bucket, key string) error) error {
+func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(reconciler.Bucket, types.NamespacedName)) error {
 	return nil
 }
 
diff --git a/pkg/reconciler/sync/sync.go b/pkg/reconciler/sync/sync.go
index 3e101ea..0d8c333 100644
--- a/pkg/reconciler/sync/sync.go
+++ b/pkg/reconciler/sync/sync.go
@@ -7,6 +7,7 @@ import (
 	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/go-git/go-git/v5/storage/memory"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/dynamic"
 	"knative.dev/pkg/logging"
 	"knative.dev/pkg/reconciler"
@@ -219,7 +220,7 @@ func splitKey(key string) (string, string, error) {
 // Ensure Reconciler implements the reconciler interface.
 var _ reconciler.LeaderAware = (*Reconciler)(nil)
 
-func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(bkt reconciler.Bucket, key string) error) error {
+func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(reconciler.Bucket, types.NamespacedName)) error {
 	return nil
 }