- Fix Release() ref counting bug: avoid calling getRef() which increments
count, instead look up ref directly and clean up when count reaches zero
- Remove unpopulated CacheStatus struct and fields from types, deepcopy,
and CRD manifest since nothing writes to them
- Extract duplicated resolveAuth into shared pkg/gitauth package with
explicit key validation for missing "username"/"password" keys
- Fix GC() race condition by skipping paths with active in-process refs
- Remove misleading WorkspaceCacheMiss metric increment for in-memory
(non-cache) code paths
- Change push controller from shallow to full clones to avoid silent
failures when transactions reference historical commits
- Add tests for ref count cleanup, ref leak prevention, GC active ref
skipping, and gitauth key validation
https://claude.ai/code/session_01WJE6ozYXZMn1CD6d4vy8b6
Add pkg/workspace.Manager that provides Acquire/Release semantics for Git
repos. When GIT_CACHE_DIR is set and a GitRepository has spec.cache.enabled,
controllers use on-disk bare clones with incremental fetch; otherwise they
fall back to the existing in-memory clone behavior.
Key changes:
- New pkg/workspace package with Manager, Workspace, GC, Deepen, and
context-based injection (WithManager/GetManager)
- GitRepository API gains spec.cache (CacheConfig) and status.cache
(CacheStatus) with deepcopy and CRD schema updates
- Push, sync, and resolver reconcilers now use workspace.Acquire/Release
instead of inline memory.NewStorage + git.CloneContext
- Shallow clone by default; sync/resolver deepen as needed for merge-base
- New Prometheus metrics: workspace_acquire_duration_seconds,
workspace_cache_hit_total, workspace_cache_miss_total
- Deployment manifests include commented-out PVC configuration
- Comprehensive unit tests for workspace package (21 tests)
- E2E tests for cache-free and cache-enabled push flows
https://claude.ai/code/session_01NULGxaCLPMT1yDVEAsffc5
