1
0
Fork 0
mirror of https://github.com/imjasonh/git-k8s synced 2026-07-06 22:12:25 +00:00
git-k8s/cmd
Claude 3b8e1bc276
Address PR review comments: fix ref counting, dedup resolveAuth, remove unused CacheStatus
- Fix Release() ref counting bug: avoid calling getRef() which increments
  count, instead look up ref directly and clean up when count reaches zero
- Remove unpopulated CacheStatus struct and fields from types, deepcopy,
  and CRD manifest since nothing writes to them
- Extract duplicated resolveAuth into shared pkg/gitauth package with
  explicit key validation for missing "username"/"password" keys
- Fix GC() race condition by skipping paths with active in-process refs
- Remove misleading WorkspaceCacheMiss metric increment for in-memory
  (non-cache) code paths
- Change push controller from shallow to full clones to avoid silent
  failures when transactions reference historical commits
- Add tests for ref count cleanup, ref leak prevention, GC active ref
  skipping, and gitauth key validation

https://claude.ai/code/session_01WJE6ozYXZMn1CD6d4vy8b6
2026-03-17 15:45:09 +00:00
..
push-controller Address PR review comments: fix ref counting, dedup resolveAuth, remove unused CacheStatus 2026-03-17 15:45:09 +00:00
repo-watcher-controller Add Prometheus metrics, health probes, Git timeouts, and unit tests 2026-03-17 14:32:02 +00:00
resolver-controller Implement PVC-backed Git workspace cache (design-pvc-workspace.md) 2026-03-17 15:20:57 +00:00
sync-controller Implement PVC-backed Git workspace cache (design-pvc-workspace.md) 2026-03-17 15:20:57 +00:00