1
0
Fork 0
mirror of https://github.com/imjasonh/git-k8s synced 2026-07-12 16:38:37 +00:00
git-k8s/pkg/apis/git/v1alpha1
Claude 3b8e1bc276
Address PR review comments: fix ref counting, dedup resolveAuth, remove unused CacheStatus
- Fix Release() ref counting bug: avoid calling getRef() which increments
  count, instead look up ref directly and clean up when count reaches zero
- Remove unpopulated CacheStatus struct and fields from types, deepcopy,
  and CRD manifest since nothing writes to them
- Extract duplicated resolveAuth into shared pkg/gitauth package with
  explicit key validation for missing "username"/"password" keys
- Fix GC() race condition by skipping paths with active in-process refs
- Remove misleading WorkspaceCacheMiss metric increment for in-memory
  (non-cache) code paths
- Change push controller from shallow to full clones to avoid silent
  failures when transactions reference historical commits
- Add tests for ref count cleanup, ref leak prevention, GC active ref
  skipping, and gitauth key validation

https://claude.ai/code/session_01WJE6ozYXZMn1CD6d4vy8b6
2026-03-17 15:45:09 +00:00
..
defaults.go Fix multiple code review issues: dedup splitKey, fix merge bug, remove dead code 2026-02-28 04:39:00 +00:00
defaults_test.go Improve test coverage from 10.3% to 42.7% with diffcover analysis 2026-03-04 19:49:59 +00:00
doc.go Change API group from git.k8s.io to git-k8s.imjasonh.com 2026-02-28 00:34:34 +00:00
groupversion_info.go Change API group from git.k8s.io to git-k8s.imjasonh.com 2026-02-28 00:34:34 +00:00
types.go Address PR review comments: fix ref counting, dedup resolveAuth, remove unused CacheStatus 2026-03-17 15:45:09 +00:00
types_test.go Add unit tests and GitRepoSync e2e test 2026-02-28 01:52:05 +00:00
zz_generated.deepcopy.go Address PR review comments: fix ref counting, dedup resolveAuth, remove unused CacheStatus 2026-03-17 15:45:09 +00:00