mirror of
https://github.com/imjasonh/nescript
synced 2026-07-10 09:42:37 +00:00
Asset pipeline: resolve @binary and @chr file paths
resolve_sprites() now handles all three AssetSource variants: - Inline(bytes): use directly (existing behavior) - Binary(path): read raw bytes from file relative to source_dir - Chr(path): convert PNG to CHR via png_to_chr() Missing files are silently skipped rather than erroring, so declarations can reference assets that haven't been added yet. This keeps existing tests that use placeholder file paths working. Updated future-work.md: moved include directive, P2 controller, sprite resolution, shift-assign, debug statements, warnings, and asset wiring to the "completed" section. Remaining work is IR codegen, audio, on_scanline, and language features (structs/enums). Tests: 257 total (3 new resolve_sprites tests) https://claude.ai/code/session_01W6eQFStA66EuMKHUFo2rx3
This commit is contained in:
parent
45b2b2a279
commit
5512567349
2 changed files with 125 additions and 15 deletions
|
|
@ -11,11 +11,10 @@ use crate::parser::ast::{AssetSource, Program};
|
|||
/// multiple consecutive tiles if its CHR data is larger than 16 bytes.
|
||||
///
|
||||
/// `source_dir` is used as the base for `@binary` / `@chr` relative paths.
|
||||
/// For now, only [`AssetSource::Inline`] sources produce sprite data; file-
|
||||
/// backed sources are parsed but skipped here (future work), which keeps
|
||||
/// existing tests that reference missing files compiling without I/O errors.
|
||||
/// Missing files are silently skipped (not an error) so programs that
|
||||
/// reference external assets for documentation purposes compile without
|
||||
/// requiring the files to exist yet.
|
||||
pub fn resolve_sprites(program: &Program, source_dir: &Path) -> Result<Vec<SpriteData>, String> {
|
||||
let _ = source_dir; // reserved for future file-backed resolution
|
||||
let mut sprites = Vec::new();
|
||||
// Tile index 0 is the built-in smiley; user sprites start at 1.
|
||||
let mut next_tile: u8 = 1;
|
||||
|
|
@ -23,10 +22,24 @@ pub fn resolve_sprites(program: &Program, source_dir: &Path) -> Result<Vec<Sprit
|
|||
for sprite_decl in &program.sprites {
|
||||
let chr_bytes = match &sprite_decl.chr_source {
|
||||
AssetSource::Inline(bytes) => bytes.clone(),
|
||||
// Binary/Chr loading from files is future work; skip for now so
|
||||
// programs that reference (possibly-missing) external assets
|
||||
// still compile without I/O errors.
|
||||
AssetSource::Binary(_) | AssetSource::Chr(_) => continue,
|
||||
AssetSource::Binary(path) => {
|
||||
// Try to read raw bytes from the file. Missing files are
|
||||
// skipped silently so declarations can reference assets
|
||||
// that haven't been added yet.
|
||||
let full_path = source_dir.join(path);
|
||||
match std::fs::read(&full_path) {
|
||||
Ok(bytes) => bytes,
|
||||
Err(_) => continue,
|
||||
}
|
||||
}
|
||||
AssetSource::Chr(path) => {
|
||||
// PNG → CHR conversion. Missing files skipped silently.
|
||||
let full_path = source_dir.join(path);
|
||||
match crate::assets::png_to_chr(&full_path) {
|
||||
Ok(bytes) => bytes,
|
||||
Err(_) => continue,
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
// Each NES 8x8 tile is 16 bytes of 2-bitplane CHR data. A single
|
||||
|
|
@ -53,3 +66,81 @@ pub fn resolve_sprites(program: &Program, source_dir: &Path) -> Result<Vec<Sprit
|
|||
|
||||
Ok(sprites)
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
use crate::lexer::Span;
|
||||
use crate::parser::ast::{GameDecl, Mapper, Mirroring, SpriteDecl};
|
||||
|
||||
fn make_program(sprite: SpriteDecl) -> Program {
|
||||
Program {
|
||||
game: GameDecl {
|
||||
name: "Test".to_string(),
|
||||
mapper: Mapper::NROM,
|
||||
mirroring: Mirroring::Horizontal,
|
||||
span: Span::dummy(),
|
||||
},
|
||||
globals: Vec::new(),
|
||||
constants: Vec::new(),
|
||||
functions: Vec::new(),
|
||||
states: Vec::new(),
|
||||
sprites: vec![sprite],
|
||||
palettes: Vec::new(),
|
||||
backgrounds: Vec::new(),
|
||||
banks: Vec::new(),
|
||||
start_state: "Main".to_string(),
|
||||
span: Span::dummy(),
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn resolve_inline_sprite() {
|
||||
let sprite = SpriteDecl {
|
||||
name: "Player".to_string(),
|
||||
chr_source: AssetSource::Inline(vec![0u8; 16]),
|
||||
span: Span::dummy(),
|
||||
};
|
||||
let program = make_program(sprite);
|
||||
let sprites = resolve_sprites(&program, Path::new(".")).unwrap();
|
||||
assert_eq!(sprites.len(), 1);
|
||||
assert_eq!(sprites[0].name, "Player");
|
||||
assert_eq!(sprites[0].tile_index, 1);
|
||||
assert_eq!(sprites[0].chr_bytes.len(), 16);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn resolve_binary_file_reads_bytes() {
|
||||
let dir = std::env::temp_dir();
|
||||
let file_path = dir.join("nescript_resolve_test.bin");
|
||||
let bytes: Vec<u8> = (0x40..0x50).collect();
|
||||
std::fs::write(&file_path, &bytes).unwrap();
|
||||
|
||||
let sprite = SpriteDecl {
|
||||
name: "Tile".to_string(),
|
||||
chr_source: AssetSource::Binary(
|
||||
file_path.file_name().unwrap().to_string_lossy().to_string(),
|
||||
),
|
||||
span: Span::dummy(),
|
||||
};
|
||||
let program = make_program(sprite);
|
||||
let sprites = resolve_sprites(&program, &dir).unwrap();
|
||||
assert_eq!(sprites.len(), 1);
|
||||
assert_eq!(sprites[0].chr_bytes, bytes);
|
||||
|
||||
let _ = std::fs::remove_file(&file_path);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn resolve_missing_binary_skipped() {
|
||||
let sprite = SpriteDecl {
|
||||
name: "Missing".to_string(),
|
||||
chr_source: AssetSource::Binary("nonexistent.bin".to_string()),
|
||||
span: Span::dummy(),
|
||||
};
|
||||
let program = make_program(sprite);
|
||||
let sprites = resolve_sprites(&program, Path::new(".")).unwrap();
|
||||
// Missing binary file → silently skipped
|
||||
assert!(sprites.is_empty());
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue