peephole: drop dead LDA #imm before mem-INC/DEC + JMP

Browse source

The IR codegen lowers `i -= 1` (and friends) into a `LoadImm temp,
1; Sub d, i, temp; StoreVar i, d` triple, and the optimizer
strength-reduces the Sub+StoreVar pair into `DEC i`. The
constant-load-into-A that used to feed the Sub stays around as a
dead `LDA #1`:

    LDA #1
    DEC ZeroPage(rem)
    JMP Label("__ir_blk_while_cond_…")

`remove_dead_loads` was set up to drop exactly this pattern but
gave up at the trailing `JMP` because it couldn't reason about
flow. Extend it to follow one unconditional `JMP <label>` to its
target and resume the dead-store scan from the next instruction.
The first instruction past the loop-condition label is reliably an
`LDA loop_var`, which overwrites A without reading it — so the
`LDA #1` is correctly identified as dead.

Conditional branches still end the scan (their not-taken path is
unconstrained) and only one JMP is followed (to keep the analysis
local). For SHA-256 specifically this drops two `LDA #1`s per
iteration of the rotate/shift bit-loops — about 1K cycles per
block. The same pattern fires across most examples' loop tails.

Verified: cargo test/clippy/fmt clean on rustc 1.95.0; emulator
harness 34/34; reproducibility diff clean; SHA-256 of "NES" still
computes to AE9145DB…4E0D. The cycle drift refreshes the four
audio hashes / golden frames timing-sensitive examples already
tracked.

https://claude.ai/code/session_01FRmSBruVWCufm3LsUVMs8v

...

This commit is contained in:

Claude 2026-04-16 17:14:34 +00:00

parent 0600f5b872

commit df71c2bf50

No known key found for this signature in database

12 changed files with 40 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

BIN

examples/arrays_and_functions.nes

View file

Binary file not shown.

BIN

examples/bitwise_ops.nes

View file

Binary file not shown.

BIN

examples/logic_ops.nes

View file

Binary file not shown.

BIN

examples/loop_break_continue.nes

View file

Binary file not shown.

BIN

examples/pong.nes

View file

Binary file not shown.

BIN

examples/sha256.nes

View file

Binary file not shown.

BIN

examples/structs_enums_for.nes

View file

Binary file not shown.

BIN

examples/two_player.nes

View file

Binary file not shown.

BIN

examples/war.nes

View file

Binary file not shown.