Claude 12b54a715e ci: emulator job must still rebuild ROMs from source ... The previous commit wired the emulator job to read the committed examples/*.nes directly, with the rationale that the `examples` job's reproducibility diff would catch "stale committed ROMs" at PR time. That reasoning is wrong and defeats the point of the emulator harness. Failure mode: a compiler change lands with correctly-rebuilt ROMs (passing the examples job) but introduces a rendering regression that flips a golden. The emulator job would catch this today because it runs the harness against freshly-compiled ROMs. With the previous commit's shortcut, the harness would boot the committed ROMs — which the PR author just rebuilt to match — so the mismatch wouldn't show up until a second commit touched anything else. That's exactly the kind of silent-failure hole the golden harness exists to plug. Fix: emulator job rebuilds the compiler (toolchain + cache + `cargo build --release`) and compiles every .ne into the workspace before running the harness, same as the pre-ROMs- committed era. The committed ROMs keep their review/demo role (clone-and-play, diff visibility in PRs) but the test job always validates the working compiler, not a frozen snapshot. CLAUDE.md updated to match: the harness runs against whatever sits in examples/*.nes, so iterating locally still means rebuilding the ROM(s) you care about first. https://claude.ai/code/session_01BcCcHi6FUmTh8jC7UgkA3A		2026-04-13 15:21:38 +00:00
..
workflows	ci: emulator job must still rebuild ROMs from source	2026-04-13 15:21:38 +00:00