mirror of
https://github.com/imjasonh/nescript
synced 2026-07-08 08:55:38 +00:00
The smoke test used to check a per-example `nonBlack` floor — "at
least one sprite rendered," plus a per-example minimum for the
multi-sprite examples. That catches gross regressions (a compiler
bug that makes everything go black) but silently lets through
anything that changes a handful of pixels without dropping below
the sprite floor. The whole point of this harness is to catch
compiler miscompiles before they land; a softer check means bugs
can still sneak in.
This swap makes every run diff the raw canvas framebuffer against
a committed PNG golden. One mismatched byte at pixel (120, 119)
is enough to fail CI — there's nowhere for a regression to hide.
Workflow:
# normal — fails on any pixel change
node tests/emulator/run_examples.mjs
# when the diff is intentional, rewrite the goldens
UPDATE_GOLDENS=1 node tests/emulator/run_examples.mjs
# or: node tests/emulator/run_examples.mjs --update-goldens
git diff tests/emulator/goldens/ # review the change
git add tests/emulator/goldens/
git commit # explain WHY in the message
When a run fails without `UPDATE_GOLDENS`, the runner writes:
tests/emulator/actual/<name>.png the run's raw output
tests/emulator/actual/<name>.diff.png red-highlighted pixel diff
so reviewers can eyeball what changed without rerunning locally.
`actual/` is gitignored and re-created on every run. The CI job
now uploads `actual/`, `goldens/`, and `report.json` together as
a single `emulator-diff` artifact on failure — side by side means
the "what changed" story is obvious without cloning.
Implementation:
- `tests/emulator/screenshots/` is renamed to `tests/emulator/goldens/`.
All 18 existing PNGs are preserved as the initial goldens (git
detected them as pure renames).
- `harness.html` gets a new `window.nesHarness.rawPixelsBase64()`
that returns the 245760-byte (256 × 240 × 4 bytes) RGBA canvas
buffer as base64. The runner compares raw pixels, not PNG
bytes, so encoder quirks (zlib level, filter heuristics) can't
cause false positives across Chrome versions or platforms.
- The runner uses `pngjs` (pure-JS, no native deps) to decode
goldens and to write diff PNGs. `PNG.sync.write` is
byte-deterministic for identical pixels, so `git diff` on a
committed golden only ever shows up when the actual rendered
pixels changed — not because two machines produced slightly
different compression.
- The committed goldens were re-encoded with pngjs in this commit
so the baseline is consistent from day one. File sizes are a
touch larger than Chrome's output (~1KB vs ~800B on average),
but that's negligible and it eliminates one entire class of
flaky-looking diffs in the future.
Determinism verification: I ran each of the 18 ROMs twice
through fresh `NES` instances in fresh puppeteer pages, hashed
the 245760-byte framebuffers at frame 180 with SHA-256, and
confirmed `run1 == run2` for every single one. Exact-pixel diffs
are safe for this ROM set.
Negative path verification: I corrupted one golden (flipped one
pixel to pure red via pngjs) and reran the runner. It printed
DIFF hello_sprite 1/61440 pixels differ; first at (120,120)
expected [255,0,0] got [0,0,0]
actual: tests/emulator/actual/hello_sprite.png
diff: tests/emulator/actual/hello_sprite.diff.png
and exited 1 as expected. The diff PNG shows a dim-grayscale
silhouette of the expected frame with a bright-red dot on the
one mismatched pixel — enough visual context to locate the
regression at a glance.
All 18 examples match their goldens in strict mode. `cargo fmt
--check`, `cargo clippy --release --all-targets -- -D warnings`,
and `cargo test --release` (313 unit + 37 integration) are all
still green.
https://claude.ai/code/session_014Z5y3Q9krLcAxYpZQJhZ5V
326 lines
12 KiB
JavaScript
326 lines
12 KiB
JavaScript
// End-to-end smoke test: runs every compiled `.nes` in `examples/`
|
|
// through a local `jsnes` (wrapped by `harness.html` in a
|
|
// puppeteer-driven headless Chrome), lets it render ~180 frames,
|
|
// grabs the raw canvas pixels, and diffs them byte-for-byte against
|
|
// a committed golden PNG under `goldens/`.
|
|
//
|
|
// The goldens are the whole contract. Any change to the compiler
|
|
// (or any regression in jsnes, or any change to this harness that
|
|
// affects rendering) will change at least one golden, and the diff
|
|
// will fail CI loudly. That's the point — it's the only way to
|
|
// catch "silently emits wrong code" bugs without writing a
|
|
// full-fat CPU test vector per example.
|
|
//
|
|
// Updating goldens:
|
|
//
|
|
// UPDATE_GOLDENS=1 node run_examples.mjs
|
|
// # or
|
|
// node run_examples.mjs --update-goldens
|
|
//
|
|
// When a diff is legitimate, rerun with that flag. It rewrites the
|
|
// PNGs in `goldens/` from whatever the harness just produced. Then
|
|
// check the new PNGs in git — `git diff goldens/*.png` lets you eye
|
|
// each change, and the commit message is where you document why.
|
|
//
|
|
// When a diff is not legitimate, the runner writes:
|
|
//
|
|
// actual/<name>.png the actual pixels for this run
|
|
// actual/<name>.diff.png red-highlighted pixel diff vs. golden
|
|
//
|
|
// so you can upload them as CI artifacts or inspect locally. The
|
|
// `actual/` directory is gitignored.
|
|
|
|
import { promises as fs } from "node:fs";
|
|
import path from "node:path";
|
|
import { fileURLToPath, pathToFileURL } from "node:url";
|
|
import puppeteer from "puppeteer";
|
|
import { PNG } from "pngjs";
|
|
|
|
const __dirname = path.dirname(fileURLToPath(import.meta.url));
|
|
const repoRoot = path.resolve(__dirname, "..", "..");
|
|
const examplesDir = path.join(repoRoot, "examples");
|
|
const goldensDir = path.join(__dirname, "goldens");
|
|
const actualDir = path.join(__dirname, "actual");
|
|
const harnessUrl = pathToFileURL(path.join(__dirname, "harness.html")).toString();
|
|
|
|
const WIDTH = 256;
|
|
const HEIGHT = 240;
|
|
const BYTES_PER_PIXEL = 4; // RGBA
|
|
const PIXEL_BYTES = WIDTH * HEIGHT * BYTES_PER_PIXEL;
|
|
|
|
const FRAMES_TO_RUN = 180; // ~3 seconds at 60 fps
|
|
const SCREENSHOT_FRAME = 180;
|
|
|
|
const updateGoldens =
|
|
process.env.UPDATE_GOLDENS === "1" ||
|
|
process.env.UPDATE_GOLDENS === "true" ||
|
|
process.argv.includes("--update-goldens");
|
|
|
|
// ── PNG helpers ────────────────────────────────────────────────
|
|
|
|
// Decode a PNG file to a raw RGBA Buffer of length PIXEL_BYTES.
|
|
// Rejects if the file doesn't exist or has the wrong dimensions.
|
|
async function decodeGolden(filePath) {
|
|
const bytes = await fs.readFile(filePath);
|
|
const png = PNG.sync.read(bytes);
|
|
if (png.width !== WIDTH || png.height !== HEIGHT) {
|
|
throw new Error(
|
|
`golden ${filePath} has wrong dimensions ${png.width}x${png.height}, expected ${WIDTH}x${HEIGHT}`,
|
|
);
|
|
}
|
|
// `png.data` is already RGBA in top-left-first row-major order.
|
|
return png.data;
|
|
}
|
|
|
|
// Encode a raw RGBA Buffer to a PNG file.
|
|
async function writePng(filePath, rgba) {
|
|
if (rgba.length !== PIXEL_BYTES) {
|
|
throw new Error(
|
|
`writePng: expected ${PIXEL_BYTES} bytes, got ${rgba.length}`,
|
|
);
|
|
}
|
|
const png = new PNG({ width: WIDTH, height: HEIGHT });
|
|
rgba.copy(png.data);
|
|
const buf = PNG.sync.write(png);
|
|
await fs.writeFile(filePath, buf);
|
|
}
|
|
|
|
// Build a diff PNG: mismatching pixels in bright red, matching
|
|
// pixels in dim grayscale so you can still see the sprite silhouettes
|
|
// for context. First differing pixel is also returned for logs.
|
|
function buildDiff(expected, actual) {
|
|
const out = Buffer.alloc(PIXEL_BYTES);
|
|
let mismatched = 0;
|
|
let firstDiff = null;
|
|
for (let i = 0; i < PIXEL_BYTES; i += 4) {
|
|
const eR = expected[i];
|
|
const eG = expected[i + 1];
|
|
const eB = expected[i + 2];
|
|
const aR = actual[i];
|
|
const aG = actual[i + 1];
|
|
const aB = actual[i + 2];
|
|
const same = eR === aR && eG === aG && eB === aB;
|
|
if (same) {
|
|
// Dim grayscale of the expected pixel — 25% brightness,
|
|
// preserves the silhouette without competing with red.
|
|
const gray = Math.round((eR * 0.299 + eG * 0.587 + eB * 0.114) * 0.25);
|
|
out[i] = gray;
|
|
out[i + 1] = gray;
|
|
out[i + 2] = gray;
|
|
out[i + 3] = 0xff;
|
|
} else {
|
|
mismatched++;
|
|
if (firstDiff === null) {
|
|
const px = (i / 4) | 0;
|
|
firstDiff = {
|
|
x: px % WIDTH,
|
|
y: (px / WIDTH) | 0,
|
|
expected: [eR, eG, eB],
|
|
actual: [aR, aG, aB],
|
|
};
|
|
}
|
|
out[i] = 0xff;
|
|
out[i + 1] = 0x00;
|
|
out[i + 2] = 0x00;
|
|
out[i + 3] = 0xff;
|
|
}
|
|
}
|
|
return { mismatched, firstDiff, rgba: out };
|
|
}
|
|
|
|
// ── ROM discovery ──────────────────────────────────────────────
|
|
|
|
async function listRoms() {
|
|
const entries = await fs.readdir(examplesDir);
|
|
return entries
|
|
.filter((f) => f.endsWith(".nes"))
|
|
.sort()
|
|
.map((f) => ({
|
|
name: f.replace(/\.nes$/, ""),
|
|
file: path.join(examplesDir, f),
|
|
}));
|
|
}
|
|
|
|
// ── Harness driver ─────────────────────────────────────────────
|
|
|
|
async function runRomInHarness(page, rom) {
|
|
const romBytes = await fs.readFile(rom.file);
|
|
const romB64 = romBytes.toString("base64");
|
|
|
|
let bootError = null;
|
|
try {
|
|
await page.evaluate((b64) => window.nesHarness.loadRomBase64(b64), romB64);
|
|
} catch (err) {
|
|
bootError = String(err);
|
|
return { bootError, rgba: null };
|
|
}
|
|
|
|
try {
|
|
// Use runFrames — a single round-trip is much faster than
|
|
// 180 separate `frame()` calls across puppeteer's RPC.
|
|
await page.evaluate(
|
|
(n) => window.nesHarness.runFrames(n),
|
|
FRAMES_TO_RUN,
|
|
);
|
|
} catch (err) {
|
|
return { bootError: String(err), rgba: null };
|
|
}
|
|
// Frame count here is a no-op marker kept for readability.
|
|
void SCREENSHOT_FRAME;
|
|
|
|
const pixelsB64 = await page.evaluate(() => window.nesHarness.rawPixelsBase64());
|
|
const rgba = Buffer.from(pixelsB64, "base64");
|
|
if (rgba.length !== PIXEL_BYTES) {
|
|
return {
|
|
bootError: `harness returned ${rgba.length} pixel bytes, expected ${PIXEL_BYTES}`,
|
|
rgba: null,
|
|
};
|
|
}
|
|
return { bootError: null, rgba };
|
|
}
|
|
|
|
// ── Main ───────────────────────────────────────────────────────
|
|
|
|
async function main() {
|
|
await fs.mkdir(goldensDir, { recursive: true });
|
|
// Wipe and recreate `actual/` so each run starts clean. This
|
|
// directory is gitignored, so it only exists to give the CI job
|
|
// something to upload when diffs fail.
|
|
await fs.rm(actualDir, { recursive: true, force: true });
|
|
await fs.mkdir(actualDir, { recursive: true });
|
|
|
|
const roms = await listRoms();
|
|
if (roms.length === 0) {
|
|
console.error("no .nes files found in examples/ — build them first");
|
|
process.exit(1);
|
|
}
|
|
|
|
const browser = await puppeteer.launch({
|
|
headless: "new",
|
|
args: ["--no-sandbox", "--disable-setuid-sandbox", "--allow-file-access-from-files"],
|
|
});
|
|
|
|
/** @type {Array<{name: string, status: string, reason: string | null}>} */
|
|
const results = [];
|
|
let failures = 0;
|
|
|
|
try {
|
|
for (const rom of roms) {
|
|
const page = await browser.newPage();
|
|
const consoleErrors = [];
|
|
page.on("pageerror", (err) => consoleErrors.push(String(err)));
|
|
page.on("console", (msg) => {
|
|
if (msg.type() === "error") consoleErrors.push(msg.text());
|
|
});
|
|
|
|
await page.goto(harnessUrl, { waitUntil: "load" });
|
|
await page.waitForFunction(
|
|
"window.nesHarness && document.getElementById('info').textContent === 'ready'",
|
|
);
|
|
|
|
const { bootError, rgba } = await runRomInHarness(page, rom);
|
|
await page.close();
|
|
|
|
if (bootError || !rgba) {
|
|
failures++;
|
|
const reason = `boot error: ${bootError ?? "no pixels"}`;
|
|
results.push({ name: rom.name, status: "FAIL", reason });
|
|
console.log(`FAIL ${rom.name.padEnd(28)} ${reason}`);
|
|
for (const e of consoleErrors) console.log(" console:", e);
|
|
continue;
|
|
}
|
|
|
|
const goldenPath = path.join(goldensDir, `${rom.name}.png`);
|
|
let goldenExists = true;
|
|
try {
|
|
await fs.access(goldenPath);
|
|
} catch {
|
|
goldenExists = false;
|
|
}
|
|
|
|
// ── Update mode ──────────────────────────────────────
|
|
if (updateGoldens) {
|
|
await writePng(goldenPath, rgba);
|
|
results.push({ name: rom.name, status: "UPDATED", reason: null });
|
|
console.log(`UPD ${rom.name.padEnd(28)} wrote golden`);
|
|
continue;
|
|
}
|
|
|
|
// ── Missing golden ──────────────────────────────────
|
|
if (!goldenExists) {
|
|
failures++;
|
|
// Write the actual so the user can inspect, then bail.
|
|
await writePng(path.join(actualDir, `${rom.name}.png`), rgba);
|
|
const reason = `no golden at ${path.relative(repoRoot, goldenPath)} — run with UPDATE_GOLDENS=1 to create`;
|
|
results.push({ name: rom.name, status: "MISSING", reason });
|
|
console.log(`MISS ${rom.name.padEnd(28)} ${reason}`);
|
|
continue;
|
|
}
|
|
|
|
// ── Byte-for-byte diff ──────────────────────────────
|
|
let golden;
|
|
try {
|
|
golden = await decodeGolden(goldenPath);
|
|
} catch (err) {
|
|
failures++;
|
|
const reason = `failed to decode golden: ${err.message}`;
|
|
results.push({ name: rom.name, status: "FAIL", reason });
|
|
console.log(`FAIL ${rom.name.padEnd(28)} ${reason}`);
|
|
continue;
|
|
}
|
|
|
|
// `rgba.equals(golden)` is an O(n) native memcmp — fastest
|
|
// path when they match, which is the common case.
|
|
if (rgba.equals(golden)) {
|
|
results.push({ name: rom.name, status: "OK", reason: null });
|
|
console.log(`OK ${rom.name.padEnd(28)} exact match`);
|
|
continue;
|
|
}
|
|
|
|
// Mismatch: write the actual and a diff PNG, record why.
|
|
const { mismatched, firstDiff, rgba: diffRgba } = buildDiff(golden, rgba);
|
|
const actualPath = path.join(actualDir, `${rom.name}.png`);
|
|
const diffPath = path.join(actualDir, `${rom.name}.diff.png`);
|
|
await writePng(actualPath, rgba);
|
|
await writePng(diffPath, diffRgba);
|
|
|
|
failures++;
|
|
const reason =
|
|
`${mismatched}/${WIDTH * HEIGHT} pixels differ; ` +
|
|
`first at (${firstDiff.x},${firstDiff.y}) ` +
|
|
`expected [${firstDiff.expected.join(",")}] ` +
|
|
`got [${firstDiff.actual.join(",")}]`;
|
|
results.push({ name: rom.name, status: "DIFF", reason });
|
|
console.log(`DIFF ${rom.name.padEnd(28)} ${reason}`);
|
|
console.log(` actual: ${path.relative(repoRoot, actualPath)}`);
|
|
console.log(` diff: ${path.relative(repoRoot, diffPath)}`);
|
|
}
|
|
} finally {
|
|
await browser.close();
|
|
}
|
|
|
|
const reportPath = path.join(__dirname, "report.json");
|
|
await fs.writeFile(
|
|
reportPath,
|
|
JSON.stringify({ generatedAt: new Date().toISOString(), updateGoldens, results }, null, 2),
|
|
);
|
|
|
|
console.log("");
|
|
console.log(`report written to ${path.relative(repoRoot, reportPath)}`);
|
|
if (updateGoldens) {
|
|
console.log(`${results.length} goldens updated`);
|
|
console.log("review the changes with `git diff tests/emulator/goldens/` before committing");
|
|
} else {
|
|
console.log(`${results.length - failures}/${results.length} ROMs match their goldens`);
|
|
if (failures > 0) {
|
|
console.log("rerun with UPDATE_GOLDENS=1 if the new output is intentional");
|
|
}
|
|
}
|
|
|
|
if (failures > 0) process.exit(1);
|
|
}
|
|
|
|
main().catch((err) => {
|
|
console.error(err);
|
|
process.exit(1);
|
|
});
|