1
0
Fork 0
mirror of https://github.com/imjasonh/nescript synced 2026-07-08 00:45:38 +00:00
nescript/examples/feature_canary.ne
Claude ee3dddb19e
examples: add feature_canary that turns red on any memory silent-drop regression
Phase 5 of the post-PR-#31 audit, and the structural piece that
closes the failure mode the earlier phases couldn't fix alone.

The audit's recurring diagnosis: pixel/audio goldens capture
*whatever* the program does, not what it *should* do. A silent
drop in codegen is still deterministic — the golden locks in
the broken behaviour and every future run agrees with it. That's
how state-locals, uninitialized struct-field writes, `on exit`
handlers, and `slow` placement each sat broken for months-to-a-
year in a green CI.

The canary inverts the relationship: the committed golden is a
solid-green universal backdrop that only appears when every
round-trip check passes. Each check writes a distinctive constant
through one language construct, reads it back, and clears
`all_ok` on mismatch. A final `if all_ok == 0 { set_palette Fail }`
flips the entire screen red for the rest of the run.

Checks cover the silent-drop shapes caught by this audit:
  - state-local variable write-read (PR #31)
  - uninitialized struct-field write-read (caught by phase 1)
  - u8 / u16 globals (u16 exercises both StoreVar + StoreVarHi)
  - array-element write at nonzero index
  - `slow`-placed global still round-trips
  - function call return value

The canary doesn't use `debug.assert` on purpose — debug-only
ops get stripped in release and the emulator harness runs
release builds. The palette swap works in release and is what
the harness pixel-diff sees.

### Why this matters as a long-lived test

The harness already had 34 pixel goldens covering full-program
behaviour, but none of them exist specifically to fail if a
*specific language feature* silently drops. The canary does.
Every silent-drop bug the audit found would have flipped it
red the moment the check was added, which is the "behaviour
assertion that can't be satisfied by silence" the plan called
for.

### Harness footprint

`tests/emulator/goldens/feature_canary.{png,audio.hash}` +
`examples/feature_canary.{ne,nes}`. 35/35 ROMs match their
goldens with the canary added. Listed in both README tables.

https://claude.ai/code/session_01AoQ678uVeqpyayvWHpfDhC
2026-04-18 00:14:40 +00:00

143 lines
4.7 KiB
Text

// Feature canary — a round-trip smoke test for memory-affecting
// language features. Every check writes a distinctive constant
// through one language construct, then reads it back and compares
// against the written value. A pass leaves the universal palette
// green; any failure flips it to red.
//
// The goal is a single emulator golden that captures the green-
// backdrop "all features round-trip correctly" state at frame 180.
// If any of the following bugs reappear, the canary turns red and
// `tests/emulator/goldens/feature_canary.png` no longer matches:
//
// - PR #31 (state-local variable writes silently dropped)
// - Uninitialized struct-field writes silently dropped (caught
// while hardening `var_addrs` in this audit)
// - `slow` placement ignored (cold var still lands in ZP)
// - u16 high byte not stored
// - Array-element write silently dropped
// - Function return value dropped
//
// Every check cascades into `all_ok` (cleared to 0 on first
// failure), so the final set_palette call picks Pass/Fail from
// one flag. We deliberately do not use `debug.assert` because
// `--debug` builds strip nothing; the palette swap works in
// release and that's what the emulator harness runs.
//
// Build: cargo run -- build examples/feature_canary.ne
game "Feature Canary" { mapper: NROM }
// ── Palettes ────────────────────────────────────────────────
//
// Pass = all-green backdrop; Fail = all-red. The canary starts
// in Pass; if any round-trip check mismatches, `set_palette Fail`
// flips the entire screen red for the rest of the run.
palette Pass {
universal: green
bg0: [dk_green, lt_green, white]
bg1: [dk_green, lt_green, white]
bg2: [dk_green, lt_green, white]
bg3: [dk_green, lt_green, white]
sp0: [black, black, black]
sp1: [black, black, black]
sp2: [black, black, black]
sp3: [black, black, black]
}
palette Fail {
universal: red
bg0: [dk_red, lt_red, white]
bg1: [dk_red, lt_red, white]
bg2: [dk_red, lt_red, white]
bg3: [dk_red, lt_red, white]
sp0: [black, black, black]
sp1: [black, black, black]
sp2: [black, black, black]
sp3: [black, black, black]
}
// ── Types and storage ──────────────────────────────────────
struct Vec2 { x: u8, y: u8 }
// Uninitialized struct global — this is the shape that was
// silently dropping field writes before the `var_addrs` fix.
var pos: Vec2
// Global u8 / u16 / array — classic globals.
var scalar: u8 = 0
var wide: u16 = 0
var row: u8[4] = [0, 0, 0, 0]
// A deliberately-cold u8 placed via `slow` so the analyzer
// keeps it outside zero-page. If `slow` regresses to advisory,
// the allocation address moves into ZP but the round-trip still
// succeeds — so this byte is for memory-map inspection, not the
// backdrop flip.
slow var cold_byte: u8 = 0
fun double_u8(x: u8) -> u8 {
return x + x
}
// ── Main state ─────────────────────────────────────────────
state Main {
// State-local — the PR #31 bug.
var local_counter: u8 = 0
// Per-frame "pass" flag. Starts true each frame; any failed
// round-trip clears it.
var all_ok: u8 = 1
on enter {
set_palette Pass
}
on frame {
all_ok = 1
// Check 1: state-local write-read.
local_counter = 42
if local_counter != 42 { all_ok = 0 }
// Check 2: uninitialized struct-field write-read.
pos.x = 99
pos.y = 77
if pos.x != 99 { all_ok = 0 }
if pos.y != 77 { all_ok = 0 }
// Check 3: global u8.
scalar = 123
if scalar != 123 { all_ok = 0 }
// Check 4: global u16 > 255 (both low and high bytes must
// land — the u16 path splits into StoreVar + StoreVarHi).
wide = 1234
if wide != 1234 { all_ok = 0 }
// Check 5: array element write-read at nonzero index.
row[2] = 55
if row[2] != 55 { all_ok = 0 }
// Check 6: slow-placed global still round-trips.
cold_byte = 200
if cold_byte != 200 { all_ok = 0 }
// Check 7: function call return value survives the
// caller's frame of reference.
var r: u8 = double_u8(21)
if r != 42 { all_ok = 0 }
// Drive the backdrop flip. `set_palette` schedules an
// update during the next vblank, so the effect lands on
// the following frame — well before the frame-180 golden
// sample.
if all_ok == 0 {
set_palette Fail
}
wait_frame
}
}
start Main