imjasonh/terraform-playground
1
0
Fork 0
mirror of https://github.com/imjasonh/terraform-playground synced 2026-07-07 23:35:16 +00:00
Code Activity

push: use a shared remote.Pusher across tags

Browse source 
Replace per-tag remote.Write/WriteIndex with a single remote.NewPusher reused
for every tag. The pusher caches per-repo upload state, so identical blobs are
checked/uploaded only once even when pushing the same digest to multiple tags
(previously each tag re-HEADed every blob). Still uploads layers/index children
concurrently via WithJobs.

Co-authored-by: Jason Hall <imjasonh@users.noreply.github.com>
This commit is contained in:
Cursor Agent 2026-06-10 23:58:03 +00:00
parent 1df0e423c5
commit 90030346c6
No known key found for this signature in database
1 changed files with 14 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

25
pymage/internal/cli/cli.go
View file

@ -337,17 +337,27 @@ func output(cmd *cobra.Command, f *buildFlags, nameOpts []name.Option, img v1.Im
if len(tags) == 0 {
tags = []string{"latest"}
}
opts := []remote.Option{
remote.WithContext(ctx),
var artifact remote.Taggable = img
if idx != nil {
artifact = idx
}
// A single Pusher is shared across all tags: it uploads layers (and, for an
// index, child manifests) concurrently, and reuses its per-repo upload state
// so identical blobs are only checked/uploaded once even across tags.
pusher, err := remote.NewPusher(
remote.WithAuthFromKeychain(authn.DefaultKeychain),
// Upload layers (and, for an index, child manifests) concurrently.
remote.WithJobs(pushConcurrency(f.pushJobs)),
)
if err != nil {
return err
}
// The artifact is pushed by content; each tag is just another pointer to
// the same digest.
for _, t := range tags {
ref := repo.Tag(t)
if err := writeArtifact(ref, img, idx, opts...); err != nil {
if err := pusher.Push(ctx, ref, artifact); err != nil {
return fmt.Errorf("push %s: %w", ref, err)
}
_, _ = fmt.Fprintf(stderr, "tagged %s -> %s@%s\n", ref, repo.Name(), digest)
@ -365,13 +375,6 @@ func artifactDigest(img v1.Image, idx v1.ImageIndex) (v1.Hash, error) {
return img.Digest()
}
func writeArtifact(ref name.Reference, img v1.Image, idx v1.ImageIndex, opts ...remote.Option) error {
if idx != nil {
return remote.WriteIndex(ref, idx, opts...)
}
return remote.Write(ref, img, opts...)
}
func writeLayout(dir string, img v1.Image, idx v1.ImageIndex) error {
p, err := layout.Write(dir, empty.Index)
if err != nil {