imjasonh/git-k8s
1
0
Fork 0
mirror of https://github.com/imjasonh/git-k8s synced 2026-07-18 15:05:45 +00:00
Code Activity

Fix LeaderAware interface: use correct Promote signature

Browse source 
The Knative reconciler.LeaderAware interface requires:
  Promote(Bucket, func(Bucket, types.NamespacedName)) error
Our code had the wrong enqueue function signature using
(Bucket, string) error instead.

https://claude.ai/code/session_01QfFzqKQUsxxBsiZUhuJ3pG
This commit is contained in:
Claude 2026-02-28 00:21:10 +00:00
parent 6ddba9902d
commit ffc7c82ae4
No known key found for this signature in database
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
pkg/reconciler/push/push.go
View file

@ -12,6 +12,7 @@ import (
corev1 "k8s.io/api/core/v1" corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/dynamic" "k8s.io/client-go/dynamic"
"k8s.io/apimachinery/pkg/types"
"knative.dev/pkg/logging" "knative.dev/pkg/logging"
"knative.dev/pkg/reconciler" "knative.dev/pkg/reconciler"
@ -254,7 +255,7 @@ func splitKey(key string) (string, string, error) {
var _ reconciler.LeaderAware = (*Reconciler)(nil) var _ reconciler.LeaderAware = (*Reconciler)(nil)
// Promote implements LeaderAware. // Promote implements LeaderAware.
func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(bkt reconciler.Bucket, key string) error) error { func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(reconciler.Bucket, types.NamespacedName)) error {
return nil return nil
} }

3
pkg/reconciler/resolver/resolver.go
View file

@ -10,6 +10,7 @@ import (
"github.com/go-git/go-git/v5/plumbing/object" "github.com/go-git/go-git/v5/plumbing/object"
"github.com/go-git/go-git/v5/storage/memory" "github.com/go-git/go-git/v5/storage/memory"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/dynamic" "k8s.io/client-go/dynamic"
"knative.dev/pkg/logging" "knative.dev/pkg/logging"
"knative.dev/pkg/reconciler" "knative.dev/pkg/reconciler"
@ -303,7 +304,7 @@ func splitKey(key string) (string, string, error) {
var _ reconciler.LeaderAware = (*Reconciler)(nil) var _ reconciler.LeaderAware = (*Reconciler)(nil)
func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(bkt reconciler.Bucket, key string) error) error { func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(reconciler.Bucket, types.NamespacedName)) error {
return nil return nil
} }

3
pkg/reconciler/sync/sync.go
View file

@ -7,6 +7,7 @@ import (
"github.com/go-git/go-git/v5/plumbing" "github.com/go-git/go-git/v5/plumbing"
"github.com/go-git/go-git/v5/storage/memory" "github.com/go-git/go-git/v5/storage/memory"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/dynamic" "k8s.io/client-go/dynamic"
"knative.dev/pkg/logging" "knative.dev/pkg/logging"
"knative.dev/pkg/reconciler" "knative.dev/pkg/reconciler"
@ -219,7 +220,7 @@ func splitKey(key string) (string, string, error) {
// Ensure Reconciler implements the reconciler interface. // Ensure Reconciler implements the reconciler interface.
var _ reconciler.LeaderAware = (*Reconciler)(nil) var _ reconciler.LeaderAware = (*Reconciler)(nil)
func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(bkt reconciler.Bucket, key string) error) error { func (r *Reconciler) Promote(bkt reconciler.Bucket, enq func(reconciler.Bucket, types.NamespacedName)) error {
return nil return nil
} }